🤖 tests: isolate project settings + right sidebar stories from app shell#3044
Open
🤖 tests: isolate project settings + right sidebar stories from app shell#3044
Conversation
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8e995c4d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/browser/features/Settings/Sections/MCPSettingsSection.stories.tsx
Outdated
Show resolved
Hide resolved
src/browser/components/WorkspaceMCPModal/WorkspaceMCPModal.stories.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@codex review Fixed the stale-client issue in both story shells — now tracking the |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@codex review Please take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the app-level
App.projectSettings.stories.tsxinto two colocated component-level story files and decouplesImmersiveReviewView.stories.tsxfrom app-level meta. All stories now render components directly with minimal provider harnesses — noAppWithMocks, noappMeta, noAppStory.Background
App-level stories navigate through the full app shell (click settings button → MCP tab → interact) which is slow, flaky across Storybook remounts, and couples tests to app-shell routing. Component-level stories render the target component directly, making them faster, more stable, and easier to maintain.
Implementation
Project settings split (14 scenarios → 2 files):
MCPSettingsSection.stories.tsx(7 scenarios) — renders the settings section directly withThemeProvider+TooltipProvider+APIProvider+ExperimentsProvider+PolicyProviderWorkspaceMCPModal.stories.tsx(7 scenarios) — renders the modal in open state directly with additionalRouterProvider+SettingsProviderApp.projectSettings.stories.tsxopenProjectSettings,openWorkspaceMCPModal,createWorkspaceMCPModalScope) replaced with direct component renderingImmersiveReviewView decoupling:
...appMetaspread +AppStorytype with localMeta<typeof ImmersiveReviewView>andStoryObj<typeof meta>layout: "fullscreen"andchromaticparameters instead of inheriting from app metaGenerated with
mux• Model:anthropic:claude-opus-4-6• Thinking:xhigh• Cost:$9.37